Re: [BUG] fill_random_bytes broken

On Thu, Jul 26 2007, Jens Axboe wrote:
> On Wed, Jul 25 2007, Shawn Lewis wrote:
> > verify.c: fill_random_bytes() doesn't work as intended.
> >
> > drand48 on linux returns a double whose value is evenly distributed between
> > 0.0 and 0.1. This is not the same as having an 8-byte value where each bit
> > has the same chance of being 0 as it does of being 1.
> >
> > I'd fix this but it should probably be done in a cross-platformish way and
> > I'm not quite sure how to do it. Maybe just use smaller randoms? Have an
> > os_random_uint32?
>
> Hmm indeed, that looks problematic. If you have a suggested fix, fire
> away :-)

OK, I just got rid of os_random_double() and used os_random_long() for
the verify stuff. It looks like it's working fine, can you confirm?

-- 
Jens Axboe