Re: Proposal to revert bfb41d98f63cb9fb72cb7c82618be10bc6d52c33

From: Jens Axboe <>
Date: Wed, 21 Nov 2007 09:36:23 +0100

On Tue, Nov 20 2007, Shawn Lewis wrote:
> Jens,
> Commit bfb41d98f63cb9fb72cb7c82618be10bc6d52c33 changed
> verify_pattern=0x55aa55aa to verify=pattern:0x55aa55aa.
> It's useful to use verify_pattern with another verify option though,
> especially the verify=meta option. Can we either revert the above commit or
> come up with another way to do both verify_pattern and verify_meta at the
> same time? I'll send a patch if we come up with a good solution.
> Maybe I should just add a verify=meta_and_pattern:0x55aa55aa option?
> My original intention in having separate verify_pattern and verify options
> was that the data that goes into the buffer should be thought of separately
> from the buffer header.

Sure, if you have a better approach I'm all for it, not too fond of the
existing one (it's confusing).

Jens Axboe
Received on Wed Nov 21 2007 - 09:36:23 CET

This archive was generated by hypermail 2.2.0 : Wed Nov 21 2007 - 10:00:02 CET