Re: [BUG] reap_threads ignores delayed jobs

From: Jens Axboe <jens.axboe_at_oracle.com>
Date: Wed, 20 Feb 2008 09:15:32 +0100

On Wed, Feb 20 2008, Aaron Carroll wrote:
> Hi,
>
> Given the following jobfile:
>
> [job1]
> filename=job1file
> size=16k
> startdelay=1
>
> ... the job never starts because reap_threads() doesn't account for delayed
> jobs in `pending'. Hence if there are no other pending jobs, the last line
> of reap_threads() executes terminate_threads(), thus killing our poor
> delayed job.
>
> The following patch seems to fix the problem, but I'm not 100% sure on the
> use of td->pid to always be zero for (and only for) pending jobs.

It should be safe, once the job transitions state to 'initialized' it
sets ->pid and it's never cleared. So the patch looks good to me,
applied.

-- 
Jens Axboe
Received on Wed Feb 20 2008 - 09:15:32 CET

This archive was generated by hypermail 2.2.0 : Wed Feb 20 2008 - 09:30:01 CET